-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply shift in investment variables #664
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing that. I have some small comments scrolling through the PR, but have no time to look deeper. Do you have some comparison plots of old vs. new for these variables? I think that would be helpful to see whether the smoothing works and the variables still have the same order of magnitude. Regarding the fixing, I have lots of trust into piamInterfaces::fixOnRef
:)
This PR is a follow-up to remindmodel/remind#1238
It applies a time shift to the following investment-related variables:
vm_deltaCap
,vm_costInvTeDir
andvm_costInvTeAdj
, affecting the variablesNew Cap|...
,Cumulative Cap|...
,Energy Investments|...
andTotal Energy costs|...
Validation:
piamInterfaces::fixOnRef
did not yield any new isues